Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 )
Change subject: Do not enter ALTERING state just for replication factor changed. ...................................................................... Patch Set 9: (3 comments) > Patch Set 6: > > (2 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/20830/3/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/20830/3/src/kudu/integration-tests/alter_table-test.cc@2652 PS3, Line 2652: unique_ptr<KuduTableAlterer> table_alterer(client_->NewTableAlterer(kTableName)); : ASSERT_OK(table_alterer->DropRangePartition(schema_.NewRow > nit: there is no need to reset the instance, it could be done in one-liner Done http://gerrit.cloudera.org:8080/#/c/20830/3/src/kudu/integration-tests/alter_table-test.cc@2661 PS3, Line 2661: kTable > Why not ASSERT_OK()? Done http://gerrit.cloudera.org:8080/#/c/20830/3/src/kudu/integration-tests/alter_table-test.cc@2667 PS3, Line 2667: > ditto: use ASSERT_OK instead of CHECK_OK? Done -- To view, visit http://gerrit.cloudera.org:8080/20830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4 Gerrit-Change-Number: 20830 Gerrit-PatchSet: 9 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 09:46:07 +0000 Gerrit-HasComments: Yes
