Hello Alexey Serbin, Kudu Jenkins, Wang Xixu,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20830
to look at the new patch set (#10).
Change subject: Do not enter ALTERING state just for replication factor changed.
......................................................................
Do not enter ALTERING state just for replication factor changed.
If we change the replication factor of a table without any tablets,
the table will stay in ALTERING state since exiting this state needs
tablet reports from the tablets of this table.
for now the condition of entering ALTERING state is as below:
has_metadata_changes && (table->num_tablets() >
tablets_to_drop.size() || num_replicas_changed);
Actually even if the number of replicas has been changed, the former
condition is also needed. So rollback the code to:
has_metadata_changes && table->num_tablets() >
tablets_to_drop.size();
Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/20830/10
--
To view, visit http://gerrit.cloudera.org:8080/20830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4
Gerrit-Change-Number: 20830
Gerrit-PatchSet: 10
Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn>
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
