Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 )
Change subject: KUDU-613: Cleanup of cache code ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/cache.h@81 PS2, Line 81: // Number of lookups for this entry. Used for upgrading to protected segment in SLRU cache. : // Resets to 0 when moved between probationary and protected segments in both directions. : uint32_t lookups; Is it possible to introduce this field only in the patch implementing the SLRU cache? http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h File src/kudu/util/nvm_cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@34 PS2, Line 34: struct LRUHandle { Any chance to unify Cache::RLHandle and this handle by templatizing? Alignment-related functionality might be introduced as an option (a template parameter). http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@46 PS2, Line 46: // Number of lookups for this entry. Used for upgrading to protected segment in SLRU cache. : // Resets to 0 when moved between probationary and protected segments in both directions. : uint32_t lookups; Ditto: is it possible to introduce this field only in the patch implementing the SLRU cache? -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 08 Feb 2024 02:31:31 +0000 Gerrit-HasComments: Yes
