Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 )
Change subject: KUDU-613: Cleanup of cache code ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/cache.h@70 PS6, Line 70: struct RLHandle { So, the decision is not to try unifying this and util::LRUHandle from nvm_cache.h? http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc@200 PS6, Line 200: util::LRUHandle nit for here and elsewhere in this file: consider introducing corresponding 'using' directive instead and dropping the 'util::' namespace prefix http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc@397 PS6, Line 397: nit: wrong indent? -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 6 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 29 Feb 2024 02:33:21 +0000 Gerrit-HasComments: Yes
