Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 )
Change subject: KUDU-613: Cleanup of cache code ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h File src/kudu/util/nvm_cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@34 PS2, Line 34: struct LRUHandle { > I'll look into it, there's some ASAN errors from trying to templatize the H It might be something related to the use cases, but overall that's quite surprising to hear about ASAN errors on that path. Another point is: while you are at this, maybe consider replacing Atomic32 with std::atomic<int32> at least? -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 13 Feb 2024 20:29:02 +0000 Gerrit-HasComments: Yes
