KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21342 )
Change subject: Minor refactoring on Op class ...................................................................... Patch Set 3: (2 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21342/2/src/kudu/tablet/ops/op.h File src/kudu/tablet/ops/op.h: http://gerrit.cloudera.org:8080/#/c/21342/2/src/kudu/tablet/ops/op.h@317 PS2, Line 317: initialize > nit: initialize it. Done http://gerrit.cloudera.org:8080/#/c/21342/2/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/21342/2/src/kudu/tablet/ops/write_op.cc@376 PS2, Line 376: : string WriteOp::ToString() const { > nit: How about simplify here when you have the chance to update the code li Done -- To view, visit http://gerrit.cloudera.org:8080/21342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie391d4a55b8da08a62025a05cc466fc2b947099c Gerrit-Change-Number: 21342 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 26 Apr 2024 09:30:43 +0000 Gerrit-HasComments: Yes
