Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 )
Change subject: Fix row_project codegen params noalias overflow ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Overall looks good to me. Just a couple of nits. http://gerrit.cloudera.org:8080/#/c/21448/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21448/1//COMMIT_MSG@9 PS1, Line 9: function->addParamAttr is 0-based indexes, current row_project generator IR code is: : `define i1 @ProjRead(i8* %src, %"class.kudu::RowBlockRow"* noalias %rbrow, %"class.kudu::Arena"* noalias %arena)` nit: alignment required. http://gerrit.cloudera.org:8080/#/c/21448/1//COMMIT_MSG@11 PS1, Line 11: with nit: as -- To view, visit http://gerrit.cloudera.org:8080/21448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a Gerrit-Change-Number: 21448 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <s...@sqh.me> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 May 2024 07:26:55 +0000 Gerrit-HasComments: Yes
