s...@sqh.me has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 )
Change subject: Fix row_project codegen params noalias overflow ...................................................................... Patch Set 2: I found this code is set paramattr noalias Attr. 1-based code will not set `i8* %src ` param noalias, which not important for IR. So 1-based code worked fine since six years.. -- To view, visit http://gerrit.cloudera.org:8080/21448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a Gerrit-Change-Number: 21448 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <s...@sqh.me> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 May 2024 09:06:52 +0000 Gerrit-HasComments: No
