Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 )
Change subject: Fix row_project codegen params noalias overflow ...................................................................... Patch Set 2: > I just wonder did kudu codegen work well if we use 1-based code. > since LLVM changed it in LLVM 5.0.0. There have at least one known issue with codegen that we faced but it is not yet established whether those were caused due to this missing change. Also, LLVM upgrade from 4.0.0 to 6.0.0 happened in 1.7.x (almost 6 years back). I am just curious, how did you discover this problem? -- To view, visit http://gerrit.cloudera.org:8080/21448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a Gerrit-Change-Number: 21448 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <s...@sqh.me> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 May 2024 08:22:25 +0000 Gerrit-HasComments: No
