Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24710 )

Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24710/5/thirdparty/vars.sh
File thirdparty/vars.sh:

PS5:
> Should PROMETHEUS also be marked as ANY_OS=1?
Perhaps, you meant ANY_OS_VERSION?

ANY_OS isn't an option: different OSes duse different executable format, they 
aren't compatible.

I guess ANY_OS_VERSION is a bit of stretch here (it relies on golang runtime 
and toolchain restrictions and the way how they build released Prometheus 
binaries), but since Kudu supports only contemporary versions of OSes, we 
should be safe adding this, I think.

Done.



--
To view, visit http://gerrit.cloudera.org:8080/24710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7
Gerrit-Change-Number: 24710
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Sat, 22 Aug 2026 18:59:14 +0000
Gerrit-HasComments: Yes

Reply via email to