Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API ......................................................................
Patch Set 1: (3 comments) Mind posting the generated Doxygen HTML somewhere so we can view the output? http://gerrit.cloudera.org:8080/#/c/3619/1/CMakeLists.txt File CMakeLists.txt: Line 972: add_custom_target(doxydocs Can we just make this part of the "make docs" target? http://gerrit.cloudera.org:8080/#/c/3619/1/docs/.gitignore File docs/.gitignore: Line 19: doxygen/** I think this is too broad, in this same commit we are adding files in a path that is covered by this pattern http://gerrit.cloudera.org:8080/#/c/3619/1/docs/support/doxygen/client.doxy File docs/support/doxygen/client.doxy: Line 1: # Doxyfile 1.8.10 Wow, do we really need this huge file? Can we just have a file that specifies the non-defaults? Also, what is the license for this file? I don't see a license header here. -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
