Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API ......................................................................
Patch Set 1: (3 comments) Thank you for review, Mike! The auto-generated docs are available at: https://alexeyserbin.github.io/ Will post the updated version soon. http://gerrit.cloudera.org:8080/#/c/3619/1/CMakeLists.txt File CMakeLists.txt: Line 972: add_custom_target(doxydocs > Can we just make this part of the "make docs" target? Make sense -- will do. http://gerrit.cloudera.org:8080/#/c/3619/1/docs/.gitignore File docs/.gitignore: Line 19: doxygen/** > I think this is too broad, in this same commit we are adding files in a pat The committed files are not covered by this pattern, actually. This pattern excludes all content below doxygen directory in the same dir as the .gitignore file. But /doxygen/ will do the job as well -- will update. http://gerrit.cloudera.org:8080/#/c/3619/1/docs/support/doxygen/client.doxy File docs/support/doxygen/client.doxy: Line 1: # Doxyfile 1.8.10 > Wow, do we really need this huge file? Can we just have a file that specifi This is the auto-generated config which doxygen outputs if running with certain options. Defaults/non-default might change from version to version, but highly unlikely. It's not needed as is -- you are right. Ok, will update to have only non-default settings here. -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
