Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API ......................................................................
Patch Set 1: (1 comment) > (3 comments) > > Thank you for review, Mike! > > The auto-generated docs are available at: > https://alexeyserbin.github.io/ I only looked briefly but noticed 2 things we probably want to change: 1. the Main page is blank 2. the includes are wrong. it says #include <client.h> but should say #include <kudu/client.h> http://gerrit.cloudera.org:8080/#/c/3619/1/docs/.gitignore File docs/.gitignore: Line 19: doxygen/** > The committed files are not covered by this pattern, actually. This patter Can we generate the doxygen files in a subdirectory of the same tree that we generate the other docs in? -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
