Github user vanzin commented on a diff in the pull request:
https://github.com/apache/incubator-livy/pull/114#discussion_r227125314
--- Diff:
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftJsonServlet.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import org.apache.livy.server.JsonServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+
+class ThriftJsonServlet(val basePath: String) extends JsonServlet {
+
+ private val df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
--- End diff --
The timezone of the logs is not really controlled by Livy, but by the
session's configuration. So it may not even be the same tz of the Livy server.
That being said I'm ok with putting the tz in the formatted date here. But
in general I prefer to return non-pre-processed data in REST APIs (e.g. the "ms
since epoch" value instead of a formatted date), and let the consumer (e.g. the
UI) deal with how to properly render the data given the context.
---
