Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/114#discussion_r227551339 --- Diff: thriftserver/server/src/main/resources/org/apache/livy/server/ui/static/js/thrift-sessions.js --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +function loadThriftSessionsTable(sessions) { + $.each(sessions, function(index, session) { + $("#thrift-sessions-table .sessions-table-body").append( + "<tr>" + + tdWrap(session.sessionId) + + tdWrap(uiLink("session/" + session.livySessionId, session.livySessionId)) + + tdWrap(session.owner) + + tdWrap(session.createdAt) + + "</tr>" --- End diff -- Ah, I think I may have emulated a DOM styling in some of my code where despite being concatenated strings I indented them like I would if they were a DOM instance (like you did here). For consistency we should probably indent them properly like concatenated strings (not DOM instances).
---