Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/114#discussion_r228309580
  
    --- Diff: 
server/src/main/resources/org/apache/livy/server/ui/static/js/all-sessions.js 
---
    @@ -26,7 +26,7 @@ function loadSessionsTable(sessions) {
             tdWrap(session.kind) +
             tdWrap(session.state) +
             tdWrap(logLinks(session, "session")) +
    -       "</tr>"
    +        "</tr>"
    --- End diff --
    
    So, neither of you guys actually understood what I was complaining about. 
The old code wasn't aligned either way. It was indented 1 space off, as you can 
see here.
    
    There's other code that's indented the way I prefer (with the close tag 
aligned with the open tag, see `session.js`).
    
    But at this point it doesn't matter. This is fine, as long as it's not 
indented wrongly like before.


---

Reply via email to