> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comments in the code to help > > all other newbies. > > > > My review was fairly narrowly focused on Java style etc. - I'm expecting > > one of the commiters will be able to give you feedback about using the > > framework. > > Jie Yu wrote: > Sorry, this is my fault. I really don't have cycle for this at this > moment. Marco, mind sherperding this patch? > > Jie Yu wrote: > The logic of this patch should match that in > src/examples/persistent_volume_framework.cpp > > Marco Massenzio wrote: > Jie - I would be absolutely happy to do that, with one minor hitch: I'm > not a committer :) > Happy to help out wherever I can, though!
Thank you very much for your review, let me update it. @marco - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33339/#review86113 ----------------------------------------------------------- On May 18, 2015, 4:42 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33339/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 4:42 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-2610 > https://issues.apache.org/jira/browse/MESOS-2610 > > > Repository: mesos > > > Description > ------- > > Add a Java example framework to test persistent volumes. > > > Diffs > ----- > > configure.ac 7f9e52916b9d78f2bbff9d6ed9871444a0fda629 > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION > src/examples/java/test-persistent-volume-framework.in PRE-CREATION > src/tests/examples_tests.cpp f85b81562158c5499e9804d8d7b6811bb0a3ef16 > src/tests/java_persistent_volume_framework_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/33339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
