> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, line 239 > > <https://reviews.apache.org/r/33339/diff/10/?file=941652#file941652line239> > > > > unless I'm mistaken and this is a unit test (is it?) can we please > > rename this class in a more meaningful way? > > > > TestXxxx should be reserved for test classes. > > haosdent huang wrote: > Hmm, name it to TestPersistentVolumeScheduler is follow other exist > examples. Like `TestScheduler` in `TestFramework.java` > > Adam B wrote: > At least a few of the other example frameworks are run as part of the > unit test suite, under ExamplesTest: > https://github.com/apache/mesos/blob/0.22.1/src/tests/examples_tests.cpp#L36 > See also: > https://github.com/apache/mesos/blob/0.22.1/src/examples/java/test-framework.in > I'm not asking you to add TestPersistentVolumeFramework to ExamplesTests > (although it would be awesome!). I'm just explaining why some of the > frameworks are named TestXxx; others are just copycats.
Hmm, it could run as a unit test. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33339/#review86113 ----------------------------------------------------------- On June 21, 2015, 5:17 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33339/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 5:17 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. > > > Bugs: MESOS-2610 > https://issues.apache.org/jira/browse/MESOS-2610 > > > Repository: mesos > > > Description > ------- > > Add a Java example framework to test persistent volumes. > > > Diffs > ----- > > configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION > src/examples/java/test-persistent-volume-framework.in PRE-CREATION > src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca > src/tests/java_persistent_volume_framework_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/33339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
