----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90796 -----------------------------------------------------------
Ship it! Looks good but see the issue below about moving this inside the translation unit. src/slave/containerizer/docker.hpp (line 239) <https://reviews.apache.org/r/36282/#comment143920> Let's not expose this in a public header since it's only used internally and instead let's just keep it as a static function inside of src/slave/containerizer/docker.cpp. src/slave/containerizer/docker.cpp (line 1551) <https://reviews.apache.org/r/36282/#comment143921> Newline above this please! src/slave/containerizer/docker.cpp (line 1552) <https://reviews.apache.org/r/36282/#comment143923> s/the os/the current process/ - Benjamin Hindman On July 7, 2015, 10:10 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36282/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 10:10 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Joerg Schad. > > > Bugs: MESOS-2996 > https://issues.apache.org/jira/browse/MESOS-2996 > > > Repository: mesos > > > Description > ------- > > Remove os environment when calling executorEnvironment when running docker > executors, since all the environment variables will be > passed into the container and causes bad behavior such as overriding hostname. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f > src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba > > Diff: https://reviews.apache.org/r/36282/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
