> On July 7, 2015, 10:58 p.m., Joerg Schad wrote: > > src/slave/containerizer/docker.cpp, line 1544 > > <https://reviews.apache.org/r/36282/diff/1/?file=1001811#file1001811line1544> > > > > Wouldn't it be easier --especially considering Adam's comment about > > MESOS-2832 and the --executor_environment_variable --- to add an additional > > (optional) flag to executorEnvironment intialize=true. if explicitly set to > > false (such as in this case, we would not initialize environment with > > os::environment().... > > Till Toenshoff wrote: > I like this approach better as well - seems much cleaner to me.
flag -> parameter... - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90814 ----------------------------------------------------------- On July 7, 2015, 10:10 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36282/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 10:10 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Joerg Schad. > > > Bugs: MESOS-2996 > https://issues.apache.org/jira/browse/MESOS-2996 > > > Repository: mesos > > > Description > ------- > > Remove os environment when calling executorEnvironment when running docker > executors, since all the environment variables will be > passed into the container and causes bad behavior such as overriding hostname. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f > src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba > > Diff: https://reviews.apache.org/r/36282/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
