----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36282/#review90802 -----------------------------------------------------------
Question about MESOS-2832, but otherwise looks good. src/slave/containerizer/docker.hpp (line 239) <https://reviews.apache.org/r/36282/#comment143934> Should executorEnvironment be static as well? src/slave/containerizer/docker.cpp (line 1552) <https://reviews.apache.org/r/36282/#comment143931> Filter? How does this cooperate with our fix for MESOS-2832 where `--executor_environment_variables` which lets an admin specify the environment variables that should be passed to an executor? Should we filter even if that flag is set? - Adam B On July 7, 2015, 3:10 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36282/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 3:10 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Joerg Schad. > > > Bugs: MESOS-2996 > https://issues.apache.org/jira/browse/MESOS-2996 > > > Repository: mesos > > > Description > ------- > > Remove os environment when calling executorEnvironment when running docker > executors, since all the environment variables will be > passed into the container and causes bad behavior such as overriding hostname. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f > src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba > > Diff: https://reviews.apache.org/r/36282/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >