> On July 17, 2015, 2:20 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 22 > > <https://reviews.apache.org/r/36501/diff/4/?file=1014441#file1014441line22> > > > > Need sort it lexicographically. > > > > ``` > > #include <sstream> > > #include <string> > > haosdent huang wrote: > ``` > #include <sstream> > #include <string> > ``` > Sorry for forgot type ```
No need sstream here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92082 ----------------------------------------------------------- On July 17, 2015, 4:13 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 4:13 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c42 > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > >
