----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92270 -----------------------------------------------------------
src/tests/fetcher_tests.cpp (line 297) <https://reviews.apache.org/r/36501/#comment146333> According https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definitioninvocation You indent is not correct here. Maybe need change to like this ``` process::http::URL url( "http", process.self().address.ip, process.self().address.port, "/help"); ``` But I perfer chang it like this ``` const network::Address& address = process.self().address; process::http::URL url("http", address.ip, address.port, "/help"); ``` Or add `using URL` like this ``` using process::Future; using process::http::URL; (Left a blank below and after process::Future) ``` and then ``` const network::Address& address = process.self().address; URL url("http", address.ip, address.port, "/help"); ``` src/tests/fetcher_tests.cpp (line 314) <https://reviews.apache.org/r/36501/#comment146334> It would be better to add ```#include <stout/stringify.hpp>``` after ```#include <stout/protobuf.hpp>``` - haosdent huang On July 18, 2015, 9:47 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 9:47 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c42 > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > >
