> On July 23, 2015, 5:42 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 1696 > > <https://reviews.apache.org/r/36620/diff/10/?file=1019693#file1019693line1696> > > > > Seems like we can just a lambda instead of a new fail method, then we > > don't even need to store chain variable right?
We need to store the chain variable for the finalize call, e.g. when the timeout kills the process. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92774 ----------------------------------------------------------- On July 24, 2015, 1:07 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 1:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
