----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review95637 -----------------------------------------------------------
Ship it! Ship It! src/linux/cgroups.cpp (line 1686) <https://reviews.apache.org/r/36620/#comment150750> More like a code suggestion, looks like reap is always called after kill, and just waiting on all the statuses you gathered. I wonder why not just move collect inside of kill(processes) in the end and return that instead of another callback? - Timothy Chen On Aug. 13, 2015, 1:52 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 1:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > + manual tests > > > Thanks, > > Joerg Schad > >
