----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 -----------------------------------------------------------
I notice there are no new tests added for this, can you add a test to verify the new change works? src/linux/cgroups.cpp (line 1689) <https://reviews.apache.org/r/36620/#comment147707> I'll move the onFailed to next line so we line up the indentation. - Timothy Chen On July 24, 2015, 1:07 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 1:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
