> On July 29, 2015, 7:12 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2128-2159 > > <https://reviews.apache.org/r/36720/diff/3/?file=1021871#file1021871line2128> > > > > Any reason you're skipping validation (authorization) of the framework? > > Looks like we should pull out the pid specific code from validate for now: > > it looks like we already have to do synchronous checks inside the > > continuations anyway. For example, `_reregisterFramework` checks to see if > > it is authenticated, but it is missing the check that it is the right > > principal! > > > > Looks like we should s/validate/authorize/ and pull out an > > `isAuthenticated` that we can call synchronously as well. > > Anand Mazumdar wrote: > Primarily due to the reasons you had mentioned earlier. There was a lot > of pid specific code in validate. Also , call validation in general were > supposed to be handled in MESOS-2497, so I refrained from making the changes. > Looks like you already did them in r36919, Thanks !
Would take up validation in a different patch as we had discussed earlier. I am dropping the issue for now. Let me know if you think otherwise. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93499 ----------------------------------------------------------- On Aug. 4, 2015, 4:33 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36720/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 4:33 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > Split review out of r36318. This change adds the functionality of making a > http call for subscribe and the master responding with a subscribed event on > the persistent stream. > > Also added functionality for framework failover equivalent of re-register. It > should now be possible to merge the subscribed(...) introduced in this review > and the re-factor that happened in MESOS-3182. > > - Made a new function for exited()/failoverFramework for http frameworks that > invoke into the common continuation function for pid/http frameworks > thereafter. > - The re-register functionality equivalent goes in _subscribe(...) > > > Diffs > ----- > > src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f > src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc > src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 > > Diff: https://reviews.apache.org/r/36720/diff/ > > > Testing > ------- > > make check + adding tests in a different patch. > > > Thanks, > > Anand Mazumdar > >
