----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94130 -----------------------------------------------------------
I'll get the exited changes committed. src/master/master.cpp (line 969) <https://reviews.apache.org/r/36720/#comment148645> Hm.. let's check that the framework ids are equal when the writers match. src/master/master.cpp (line 971) <https://reviews.apache.org/r/36720/#comment148644> s/exited/disconnection/ src/master/master.cpp (line 1021) <https://reviews.apache.org/r/36720/#comment148648> Let's put `_exited` after both `exited` implementations, since it is a shared continuation. - Ben Mahler On Aug. 4, 2015, 10 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36720/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 10 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > Split review out of r36318. This change adds the functionality of making a > http call for subscribe and the master responding with a subscribed event on > the persistent stream. > > Also added functionality for framework failover equivalent of re-register. It > should now be possible to merge the subscribed(...) introduced in this review > and the re-factor that happened in MESOS-3182. > > - Made a new function for exited()/failoverFramework for http frameworks that > invoke into the common continuation function for pid/http frameworks > thereafter. > - The re-register functionality equivalent goes in _subscribe(...) > > > Diffs > ----- > > src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 > src/master/master.hpp cd0a5c863d4f74c3bcfd61d8e3046b3ab249be67 > src/master/master.cpp 87e11d512f68e2b7285ee1901d422991208baf15 > > Diff: https://reviews.apache.org/r/36720/diff/ > > > Testing > ------- > > make check + adding tests in a different patch. > > > Thanks, > > Anand Mazumdar > >
