> On Aug. 6, 2015, 6:39 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 4990 > > <https://reviews.apache.org/r/36720/diff/9/?file=1033626#file1033626line4990> > > > > Don't we still want this since we call pid.get()?
Persisted the CHECK_SOME. Removed the misleading message though as we have now implemented http framework failover. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94428 ----------------------------------------------------------- On Aug. 6, 2015, 4:25 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36720/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 4:25 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2294 > https://issues.apache.org/jira/browse/MESOS-2294 > > > Repository: mesos > > > Description > ------- > > Split review out of r36318. This change adds the functionality of making a > http call for subscribe and the master responding with a subscribed event on > the persistent stream. > > Also added functionality for framework failover equivalent of re-register. It > should now be possible to merge the subscribed(...) introduced in this review > and the re-factor that happened in MESOS-3182. > > - Made a new function for exited()/failoverFramework for http frameworks that > invoke into the common continuation function for pid/http frameworks > thereafter. > - The re-register functionality equivalent goes in _subscribe(...) > > > Diffs > ----- > > src/common/http.hpp 9e4290f9e1f72730f63466d498a953cc5031a92b > src/common/http.cpp a74c51d9392d0b0a67d51a0143eb314cfca11245 > src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 > src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db > src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 > > Diff: https://reviews.apache.org/r/36720/diff/ > > > Testing > ------- > > make check + adding tests in a different patch. > > > Thanks, > > Anand Mazumdar > >