> On Aug. 12, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/backend.hpp, line 48 > > <https://reviews.apache.org/r/37382/diff/1/?file=1038090#file1038090line48> > > > > Should we just use Path here?
Path is still hard to use in an interface particularly when it comes to joins: Path is implicitly convertable to string but not vice versa, join results are strings; already checked in code in the provisioning / FS isolation components don't use Path in the interface. We can revisit this in the future but for now I think we should still use string. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95069 ----------------------------------------------------------- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37382/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 10:51 a.m.) > > > Review request for mesos, Lily Chen, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2968 > https://issues.apache.org/jira/browse/MESOS-2968 > > > Repository: mesos > > > Description > ------- > > The Backend interface is made generic so it can be used by different > provisioners. See > [MESOS-2968](https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859) > for details. > > > Diffs > ----- > > src/Makefile.am b5dbdc316cad179cd265bd81900999fab35940b9 > src/slave/containerizer/provisioners/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/backend.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37382/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
