> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.hpp, line 54 > > <https://reviews.apache.org/r/37197/diff/10/?file=1052419#file1052419line54> > > > > `DockerImage` is not defined by this RR but by 37198. We usually go > > with one of those two options here; > > A. mark the entire chain as "must get committed entirely" > > B. make sure each RR is committable without breaking build (or function)
We'll commit all together. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review96496 ----------------------------------------------------------- On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
