----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111528 -----------------------------------------------------------
Thanks, this is a big improvement! include/mesos/authorizer/authorizer.hpp (line 35) <https://reviews.apache.org/r/41444/#comment171723> s/authorization for/authorization of/ include/mesos/authorizer/authorizer.hpp (lines 73 - 74) <https://reviews.apache.org/r/41444/#comment171724> s/module only/module-only/ s/module specific/module-specific/ include/mesos/authorizer/authorizer.hpp (lines 111 - 113) <https://reviews.apache.org/r/41444/#comment171754> Though I know what you're saying here, this one sounds a bit confusing to me. I wonder if something more concise like "shut down a framework registered by another framework principal." might be clearer? include/mesos/authorizer/authorizer.hpp (line 182) <https://reviews.apache.org/r/41444/#comment171752> s/quota with the/quota for the/ - Greg Mann On Dec. 21, 2015, 4:04 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 4:04 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
