----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111845 -----------------------------------------------------------
Ship it! Awesome! Few minor tweaks and we can ship it! include/mesos/authorizer/authorizer.hpp (line 42) <https://reviews.apache.org/r/41444/#comment172134> "checked"? You mean, "the request could not be completed"? or "made" or "authorized"? include/mesos/authorizer/authorizer.hpp (line 45) <https://reviews.apache.org/r/41444/#comment172135> "streamlining"? You mean "bundling" or "collecting" or just "allows multiple values"? include/mesos/authorizer/authorizer.hpp (line 47) <https://reviews.apache.org/r/41444/#comment172136> s/we do not use it in Mesos code/Mesos code currently does not authorize multiple entities in a single call/ include/mesos/authorizer/authorizer.hpp (line 115) <https://reviews.apache.org/r/41444/#comment172137> where did `framework_principal` come from? YOu only talk about "the framework principal" prior to this. Don't introduce a new special term unnecessarily. include/mesos/authorizer/authorizer.hpp (line 181) <https://reviews.apache.org/r/41444/#comment172138> s/request/set/? - Adam B On Dec. 22, 2015, 5:53 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 5:53 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >