> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 42 > > <https://reviews.apache.org/r/41444/diff/4/?file=1174504#file1174504line42> > > > > "checked"? You mean, "the request could not be completed"? or "made" or > > "authorized"?
I like "completed". > On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 45 > > <https://reviews.apache.org/r/41444/diff/4/?file=1174504#file1174504line45> > > > > "streamlining"? You mean "bundling" or "collecting" or just "allows > > multiple values"? Let's go for "bundling". > On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 47 > > <https://reviews.apache.org/r/41444/diff/4/?file=1174504#file1174504line47> > > > > s/we do not use it in Mesos code/Mesos code currently does not > > authorize multiple entities in a single call/ I'd say it's a bit misleading. Multiple entities are not allowed, but multiple values in a single entity are. How about "Mesos code currently does not authorize multiple principals in a single call"? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111845 ----------------------------------------------------------- On Dec. 22, 2015, 1:53 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 1:53 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
