----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43582/#review119229 -----------------------------------------------------------
src/slave/flags.cpp (lines 397 - 403) <https://reviews.apache.org/r/43582/#comment180503> My $0.02: this flag makes it sound like we are "enabling systemd" not "enabling moving executors and associated processes into a systemd slice". IMHO this could mean two different things in the future, i.e., we want to enable systemd for one thing but not for moving executors? I'd call out the moving executors support explicitly in this flag, perhaps: `systemd_enable_executors_slice` or a better name if you decided previously to not call it an executor slice any more because it holds more than just executors. - Benjamin Hindman On Feb. 15, 2016, 5:37 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43582/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 5:37 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4675 > https://issues.apache.org/jira/browse/MESOS-4675 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/systemd.hpp d868fda3d77eb8f42a5ec9877af2e6a79bbec228 > src/linux/systemd.cpp 13b5c8212c97912cae44fd0d7c92c93a714f695d > src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d > src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/43582/diff/ > > > Testing > ------- > > run on systemd system with flag disabled. > > > Thanks, > > Joris Van Remoortere > >
