----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43582/#review119234 -----------------------------------------------------------
src/linux/systemd.cpp (line 52) <https://reviews.apache.org/r/43582/#comment180514> does it make sense to have the same order here as above in the hpp? src/slave/flags.hpp (line 97) <https://reviews.apache.org/r/43582/#comment180512> Should we document this in configure.md? src/slave/flags.cpp (line 399) <https://reviews.apache.org/r/43582/#comment180513> What precisly do you mean by `Top level control systemd support`? src/slave/main.cpp (line 243) <https://reviews.apache.org/r/43582/#comment180515> Isn't flags.systemd_enable_support always true at this point? Feel free to drop, but I personally feel `true` would be easier to read. - Joerg Schad On Feb. 15, 2016, 5:59 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43582/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 5:59 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4675 > https://issues.apache.org/jira/browse/MESOS-4675 > > > Repository: mesos > > > Description > ------- > > Added flag to disable system support. > > > Diffs > ----- > > src/linux/systemd.hpp d868fda3d77eb8f42a5ec9877af2e6a79bbec228 > src/linux/systemd.cpp 13b5c8212c97912cae44fd0d7c92c93a714f695d > src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d > src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/43582/diff/ > > > Testing > ------- > > run on systemd system with flag disabled. > > > Thanks, > > Joris Van Remoortere > >
