----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43582/#review119231 -----------------------------------------------------------
Fix it, then Ship it! src/linux/systemd.cpp (line 55) <https://reviews.apache.org/r/43582/#comment180505> "... are enabled unless there is an explicit flag to disable these (see other flags)." src/slave/flags.cpp (line 400) <https://reviews.apache.org/r/43582/#comment180506> See comment above. - Benjamin Hindman On Feb. 15, 2016, 5:59 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43582/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 5:59 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4675 > https://issues.apache.org/jira/browse/MESOS-4675 > > > Repository: mesos > > > Description > ------- > > Added flag to disable system support. > > > Diffs > ----- > > src/linux/systemd.hpp d868fda3d77eb8f42a5ec9877af2e6a79bbec228 > src/linux/systemd.cpp 13b5c8212c97912cae44fd0d7c92c93a714f695d > src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d > src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 > src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 > > Diff: https://reviews.apache.org/r/43582/diff/ > > > Testing > ------- > > run on systemd system with flag disabled. > > > Thanks, > > Joris Van Remoortere > >