----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review120338 -----------------------------------------------------------
Apologies, did you check with Alex prior to committing? We talked about this change recently but we didn't publish the comments, sorry that it wasn't clear! I reverted it for now, since we didn't really like the empty map constants as class members. We also needed to look into whether using empty initializer lists inline worked instead of this change. - Ben Mahler On Jan. 28, 2016, 1:12 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41950/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 1:12 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris > Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Changes made: > - empty resource map promoted to a const class field; > - removed variable numeric suffixes where appropriate; > - added const where appropriate. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > f18e6eb10572b0f5b8bbff338384d9406f6ad62b > > Diff: https://reviews.apache.org/r/41950/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > > `make check` > > `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh > --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle` > > > Thanks, > > Alexander Rukletsov > >
