----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120431 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 286) <https://reviews.apache.org/r/43879/#comment181869> some comments here src/tests/hierarchical_allocator_tests.cpp (line 31) <https://reviews.apache.org/r/43879/#comment181870> This include should be put in a new section under `#include <process/queue.hpp>` src/tests/hierarchical_allocator_tests.cpp (line 2288) <https://reviews.apache.org/r/43879/#comment181871> 4 spaces src/tests/hierarchical_allocator_tests.cpp (lines 2306 - 2310) <https://reviews.apache.org/r/43879/#comment181874> if (metrics.values.count(metric)) { return metrics.find<JSON::Number>(metric)->as<double>(); } return None(); - Guangya Liu On 二月 23, 2016, 5:09 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43879/ > ----------------------------------------------------------- > > (Updated 二月 23, 2016, 5:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for number of allocations made. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0d39d3f3b5f4ff7f62f9de7200d062845c71818a > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 1af5c9870430eb05ca0b19ece0ca2957a05093ff > > Diff: https://reviews.apache.org/r/43879/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
