> On 二月 24, 2016, 1:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > <https://reviews.apache.org/r/43879/diff/1/?file=1265543#file1265543line286> > > > > some comments here > > Benjamin Bannier wrote: > For variables which such narrow usage I would prefer to give them a > speaking name; do you have a suggestion you find easier to understand?
The reason that I want to have some comments here is because the `allocation_runs` is a bit ambigous, i do not know if this counter was increased when there are allocations no matter succeed or not, or allocations succeed. I was that there are indeed some metrics include comments: https://github.com/apache/mesos/blob/master/src/master/metrics.hpp#L73-L77 - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120431 ----------------------------------------------------------- On 二月 24, 2016, 8:46 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43879/ > ----------------------------------------------------------- > > (Updated 二月 24, 2016, 8:46 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for number of allocations made. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43879/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >