> On Feb. 24, 2016, 2:06 p.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2398
> > <https://reviews.apache.org/r/43879/diff/3/?file=1267167#file1267167line2398>
> >
> > I saw that most are using `Seconds(15)`
>
> Guangya Liu wrote:
> Can you please clarify why using `Seconds{15}` but not `Seconds(15)`?
> What is the difference?
>
> Benjamin Bannier wrote:
> Let's stay consistent with how constructor calls are written here now.
`Seconds{15}` is a call to a constructor of type `Seconds` without narrowing,
while `Seconds(15)` could be e.g., a constructor call, a function call, a macro
invocation, with narrowing sprinkled in where the compiler might need it.
That's why IMHO the first form is clearer and less magic.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43879/#review120492
-----------------------------------------------------------
On Feb. 24, 2016, 2:25 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43879/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 2:25 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4718
> https://issues.apache.org/jira/browse/MESOS-4718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added allocator metrics for number of allocations made.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp
> 3043888630b066505410d3b32c5b3f813cc458c1
> src/master/allocator/mesos/hierarchical.cpp
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d
> src/tests/hierarchical_allocator_tests.cpp
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33
>
> Diff: https://reviews.apache.org/r/43879/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
> I confirmed that this does not lead to general performance regressions in the
> allocator; this is partially expected since the added code only inserts
> metrics in the allocator while the actual work is perform asynchronously.
> These tests where performed with
> `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build
> under OS X using clang(trunk) as compiler.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
