> On Feb. 25, 2016, 12:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1204 > > <https://reviews.apache.org/r/43881/diff/5/?file=1268420#file1268420line1204> > > > > Even though I really like the anonymous namespace, we don't use it for > > some reasons (I think the main one is that symbols are still exported, even > > though with mangled names). > > > > All in all, there is only one place in non automatically generated code > > which uses them (and I wonder how it managed). > > > > All this to say, I guess this function should be static. > > > > Moreover, does this need to be a free function? I much rather have a > > private method.
I introduced a type here so only an anon namespace would have prevented public linkage. I removed the anon namespace and documented the type now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120597 ----------------------------------------------------------- On Feb. 25, 2016, 12:37 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43881/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 12:37 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4719 > https://issues.apache.org/jira/browse/MESOS-4719 > > > Repository: mesos > > > Description > ------- > > Added allocator metric for the number of allocations to a framework. > > > Diffs > ----- > > docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43881/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
