> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > <https://reviews.apache.org/r/43881/diff/7/?file=1270846#file1270846line376> > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framework. > > Benjamin Bannier wrote: > Right now this is intended behavior, any preference @bmahler?
For the cluster running for a long time, there'll be several un-available metrics after doing operation. Just go through the other patches of metrics, similar comments on quota and filters. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review120716 ----------------------------------------------------------- On Feb. 27, 2016, 1:02 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43881/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 1:02 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4719 > https://issues.apache.org/jira/browse/MESOS-4719 > > > Repository: mesos > > > Description > ------- > > Added allocator metric for the number of allocations to a framework. > > > Diffs > ----- > > docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43881/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
