> On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2432-2436 > > <https://reviews.apache.org/r/43881/diff/8/?file=1272155#file1272155line2432> > > > > This looks rather hard to read. I think a better solution would look > > like this: > > > > ```c++ > > std::string metricKey = strings::join("/", > > "allocator/framework_allocations", framework.id()); > > > > EXPECT_EQ(1, metrics.values[metricKey]); > > ```
Done. > On Feb. 27, 2016, 1:25 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2471-2480 > > <https://reviews.apache.org/r/43881/diff/8/?file=1272155#file1272155line2471> > > > > Same as above. Done. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121001 ----------------------------------------------------------- On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43881/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 10:28 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4719 > https://issues.apache.org/jira/browse/MESOS-4719 > > > Repository: mesos > > > Description > ------- > > Added allocator metric for the number of allocations to a framework. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43881/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >