> On March 9, 2016, 10:18 a.m., Adam B wrote: > > src/master/master.cpp, line 2837 > > <https://reviews.apache.org/r/44322/diff/5/?file=1292969#file1292969line2837> > > > > When would this ever be empty? Shouldn't we have validated somewhere > > prior that the Reserve operation is reserving at least one resource/role? > > I'd think this could be a CHECK. > > Alexander Rojas wrote: > Well, this version is consistent with the current semantics. I think > having non resource is equivalent to request for all of them.
Based on our offline talk: We cannot add a check because we cannot guarantee that the request validation was executed before this authorization request. So I added a note stating that and a TODO so that we ensure validation before authorization. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122699 ----------------------------------------------------------- On March 9, 2016, 3:10 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44322/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 3:10 p.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-2950 > https://issues.apache.org/jira/browse/MESOS-2950 > > > Repository: mesos > > > Description > ------- > > **WIP: Do not commit** > > Implements the later [Generic Authorizer Interface v > 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ) > proposal. > > It still lacks some parts: > > - [ ] Doxygen in the interface. > - [ ] Updating `authorizer.md` > > Still the basic functionality is there and I don't expect it to change > much. As I mentioned, comments aren't there yet but feel free to point > where they are missed, at this point focusing in the actual content > may not be relevant as the patch may change from its current form. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 705482656788ac12e9d21e355b71fd2ede2be558 > include/mesos/authorizer/authorizer.proto PRE-CREATION > src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f > src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 > src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2 > src/authorizer/local/authorizer.hpp > c87a9915bae6bae7744bd57abd12e8d857181051 > src/authorizer/local/authorizer.cpp > 15c857de79cd7dd2c29b6b8cfb81204b919f1b28 > src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df > src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc > src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08 > src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5 > src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3 > src/tests/master_authorization_tests.cpp > 29c89fb11da792c3e71eb880a19657ea225b3cc8 > src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581 > src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b > src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 > > Diff: https://reviews.apache.org/r/44322/diff/ > > > Testing > ------- > > make -j4 check > > > Thanks, > > Alexander Rojas > >