----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124366 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 679) <https://reviews.apache.org/r/44435/#comment186881> s/'launchInfos'/`launchInfos` src/slave/containerizer/mesos/containerizer.cpp (line 680) <https://reviews.apache.org/r/44435/#comment186880> s/because otherwise,/because otherwise, if the `prepare` in isolator did not return `launchInfos` in some failure cases (MESOS-4878), ? src/tests/containerizer/mesos_containerizer_tests.cpp (lines 713 - 719) <https://reviews.apache.org/r/44435/#comment186883> The jagged format is not good and a patch https://reviews.apache.org/r/44653/diff/5#index_header is already trying to fix such issues. It is better use following format: MOCK_METHOD2( recover, Future<Nothing>( const list<ContainerState>&, const hashset<ContainerID>&)); src/tests/containerizer/mesos_containerizer_tests.cpp (line 740) <https://reviews.apache.org/r/44435/#comment186882> a period - Guangya Liu On 三月 19, 2016, 2:29 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44435/ > ----------------------------------------------------------- > > (Updated 三月 19, 2016, 2:29 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4878 > https://issues.apache.org/jira/browse/MESOS-4878 > > > Repository: mesos > > > Description > ------- > > Fixed a bug that causes the task stuck in staging state. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4638d08328127a8c4ae37555f2be74fe9695da31 > src/tests/containerizer/mesos_containerizer_tests.cpp > e849932ab558ccd792080433169ae50dc208a12e > > Diff: https://reviews.apache.org/r/44435/diff/ > > > Testing > ------- > > - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"` > - make check > > > Thanks, > > Shuai Lin > >
