> On April 5, 2016, 10:25 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 286 > > <https://reviews.apache.org/r/44946/diff/14/?file=1324703#file1324703line286> > > > > `s/directory/path`.
As discussed, we only accept directories now. > On April 5, 2016, 10:25 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.hpp, lines 61-62 > > <https://reviews.apache.org/r/44946/diff/14/?file=1324702#file1324702line61> > > > > s/directory/path/, this breaks the symmetry in the `*projectId` methods > > but this doesn't need to be a directory and we actually use it to test > > files in tests. As discussed we only accept directories now. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127166 ----------------------------------------------------------- On April 5, 2016, 11:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44946/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 11:15 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-4828 > https://issues.apache.org/jira/browse/MESOS-4828 > > > Repository: mesos > > > Description > ------- > > Add utility functions to manipulate XFS project quotas. > > > Diffs > ----- > > src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > src/tests/environment.cpp 2afaa328a0fb226a2d1ca35a4754ccb274bc075d > > Diff: https://reviews.apache.org/r/44946/diff/ > > > Testing > ------- > > Make check. Manual verification. Tests in subsequent patches. > > > Thanks, > > James Peach > >
