----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126511 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 413 - 419) <https://reviews.apache.org/r/45571/#comment189517> I do not think we need this. If agent crashes after removing the interface directory in `_detach`, then we should not get into this `foreach` loop because `networkNames` returned by `paths::getNetworkNames` should be empty. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 457 - 462) <https://reviews.apache.org/r/45571/#comment189523> Is it possible that agent crashes when checkpointing the output of CNI plugin in `_attach`? Will it cause this file corrupt or only contain partial output of plugin? If so, then we may log a warning message and just continue here. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 826) <https://reviews.apache.org/r/45571/#comment189525> I think we need a `CHECK(infos.contains(containerId));` here. - Qian Zhang On April 1, 2016, 9:08 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45571/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 9:08 a.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > A few cleanups and simplifications in CNI isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3a07540909ed771d1bd3b22888e04d5fb451710d > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
