> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 374 > > <https://reviews.apache.org/r/45571/diff/1/?file=1321722#file1321722line374> > > > > s/on/only > > instead of `non-host network(s)` maybe `joined a CNI network(s) ? > > > > Didn't follow the last part of the sentence "and cleanup _might_ be > > required for that container." What does this mean ?
Add a few more to explain that does that mean. > On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > <https://reviews.apache.org/r/45571/diff/1/?file=1321722#file1321722line429> > > > > You had mentioned that if we return an error during `recover` the agent > > will restart. This state from checkpointed information that is not > > changing. After restart would the Agent end up hitting this condition again > > ? Yes, but this is not possible, right? If that happens, human needs to be involved. > On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 475 > > <https://reviews.apache.org/r/45571/diff/1/?file=1321722#file1321722line475> > > > > s/crashes/crashed/ > > Why would cleanup be called on this container? Cause they are `orphans`? No, the agent hasn't realized that the container cleanup has done. So after restart, it'll call cleanup again. > On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1016 > > <https://reviews.apache.org/r/45571/diff/1/?file=1321722#file1321722line1016> > > > > Maybe "failed to detech container " + containerId + " from network '" > > ..... 'containerId' is not needed here because the caller will print it. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126592 ----------------------------------------------------------- On April 1, 2016, 1:08 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45571/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 1:08 a.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > A few cleanups and simplifications in CNI isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3a07540909ed771d1bd3b22888e04d5fb451710d > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >