> On April 1, 2016, 4:46 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 429 > > <https://reviews.apache.org/r/45571/diff/1/?file=1321722#file1321722line429> > > > > You had mentioned that if we return an error during `recover` the agent > > will restart. This state from checkpointed information that is not > > changing. After restart would the Agent end up hitting this condition again > > ? > > Jie Yu wrote: > Yes, but this is not possible, right? If that happens, human needs to be > involved. > > Avinash sridharan wrote: > Yeah, we can't handle this condition. Should we add a `LOG(ERROR)` here > or would this be highlighted upstream? Wanted to see if we can explicitly > indicate this condition to the operator.
I think the Error message will be visible to the operator? Why you need a LOG(ERROR) here. The agent (or containerizer) will do the LOG(ERROR). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45571/#review126592 ----------------------------------------------------------- On April 1, 2016, 5:36 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45571/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 5:36 p.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > A few cleanups and simplifications in CNI isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3a07540909ed771d1bd3b22888e04d5fb451710d > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
